Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: checkpoint api optimization #2072

Merged
merged 1 commit into from
Aug 10, 2018
Merged

api: checkpoint api optimization #2072

merged 1 commit into from
Aug 10, 2018

Conversation

Ace-Tang
Copy link
Contributor

Signed-off-by: Ace-Tang aceapril@126.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

apis/swagger.yml Outdated
schema:
$ref: "#/definitions/Error"
404:
description: "No such exec instance"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/exec/checkpoint ?
@Ace-Tang

apis/swagger.yml Outdated
$ref: "#/responses/500ErrorResponse"
tags: ["Container"]

/exec/{id}/start:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this part.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@a77e0da). Click here to learn what that means.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2072   +/-   ##
=========================================
  Coverage          ?   63.52%           
=========================================
  Files             ?      207           
  Lines             ?    16122           
  Branches          ?        0           
=========================================
  Hits              ?    10242           
  Misses            ?     4598           
  Partials          ?     1282
Flag Coverage Δ
#criv1alpha1test 32.73% <0%> (?)
#criv1alpha2test 33.4% <0%> (?)
#integrationtest 37.7% <25%> (?)
#unittest 23.65% <0%> (?)
Impacted Files Coverage Δ
daemon/mgr/container_checkpoint.go 21.68% <0%> (ø)
apis/server/container_bridge.go 79.69% <80%> (ø)

@allencloud
Copy link
Collaborator

LGTM if the CIs are all green.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 10, 2018
Signed-off-by: Ace-Tang <aceapril@126.com>
@allencloud
Copy link
Collaborator

I do not think the CI failure is related to the code change
warning: no packages being tested depend on github.com/alibaba/pouch/apis/filters warning: no packages being tested depend on github.com/alibaba/pouch/credential warning: no packages being tested depend on github.com/alibaba/pouch/daemon/events warning: no packages being tested depend on github.com/alibaba/pouch/pkg/term install install bin/pouch /usr/local/bin install bin/pouchd /usr/local/bin download_dependencies hack/install/install_ci_related.sh instsall CI related tools... package golang.org/x/tools/cover: unrecognized import path "golang.org/x/tools/cover" (https fetch: Get https://golang.org/x/tools/cover?go-get=1: dial tcp 74.125.202.141:443: i/o timeout)

@allencloud allencloud merged commit fcd1653 into AliyunContainerService:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants