Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for storage module #2089

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Aug 14, 2018

Ⅰ. Describe what this PR did

Add unit-test for storage module.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

@allencloud
Copy link
Collaborator

Unit test fails. @rudyfly PTAL

Add unit-test for storage module.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #2089 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2089      +/-   ##
==========================================
+ Coverage      65%   65.31%   +0.31%     
==========================================
  Files         209      209              
  Lines       16227    16220       -7     
==========================================
+ Hits        10548    10594      +46     
+ Misses       4370     4322      -48     
+ Partials     1309     1304       -5
Flag Coverage Δ
#criv1alpha1test 33.37% <ø> (ø) ⬆️
#criv1alpha2test 34.02% <ø> (+0.02%) ⬆️
#integrationtest 39.95% <ø> (+0.06%) ⬆️
#unittest 24.22% <ø> (+0.4%) ⬆️
Impacted Files Coverage Δ
storage/volume/driver/driver.go 68.03% <ø> (+23.07%) ⬆️
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️
ctrd/image.go 76.75% <0%> (-2.2%) ⬇️
ctrd/watch.go 75.75% <0%> (+3.03%) ⬆️
storage/volume/driver/proxy.go 79.45% <0%> (+26.02%) ⬆️
storage/volume/driver/fake_driver.go 50% <0%> (+50%) ⬆️

@rudyfly
Copy link
Collaborator Author

rudyfly commented Aug 14, 2018

@allencloud PTAL 🍺

@rudyfly rudyfly closed this Aug 14, 2018
@rudyfly rudyfly reopened this Aug 14, 2018
@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 14, 2018
@allencloud allencloud merged commit 701e795 into AliyunContainerService:master Aug 14, 2018
@rudyfly rudyfly deleted the volume_unittest branch October 29, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/storage areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants