cgroup: enable memory swappiness equal to -1 #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ace-Tang <aceapril@126.com>
HusterWan
reviewed
Aug 14, 2018
| @@ -6,7 +6,7 @@ import "fmt" | |||
|
|
|||
| // ValidateMemorySwappiness verifies the correctness of memory-swappiness. | |||
| func ValidateMemorySwappiness(memorySwappiness int64) error { | |||
| if memorySwappiness < 0 || memorySwappiness > 100 { | |||
| if memorySwappiness != -1 && (memorySwappiness < 0 || memorySwappiness > 100) { | |||
There was a problem hiding this comment.
how about if (memorySwappiness < -1 || memorySwappiness > 100)
There was a problem hiding this comment.
Do not do this, [0, 100] is a valid value, -1 is the value we enable to follow with moby.
HusterWan
reviewed
Aug 14, 2018
| @@ -100,7 +100,7 @@ func validateResource(r *types.Resources, update bool) ([]string, error) { | |||
| warnings = append(warnings, MemorySwappinessWarn) | |||
| r.MemorySwappiness = nil | |||
| } | |||
| if r.MemorySwappiness != nil && (*r.MemorySwappiness < 0 || *r.MemorySwappiness > 100) { | |||
| if r.MemorySwappiness != nil && *r.MemorySwappiness != -1 && (*r.MemorySwappiness < 0 || *r.MemorySwappiness > 100) { | |||
There was a problem hiding this comment.
how about if r.MemorySwappiness != nil (*r.MemorySwappiness < -1 || *r.MemorySwappiness > 100)
Codecov Report
@@ Coverage Diff @@
## master #2092 +/- ##
==========================================
- Coverage 65.02% 64.98% -0.04%
==========================================
Files 209 209
Lines 16227 16227
==========================================
- Hits 10551 10545 -6
- Misses 4368 4372 +4
- Partials 1308 1310 +2
|
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
enable memory-swappiness can be set to -1, -1 means do nothing.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
add！
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews