feature: add disk quota for container metadata directory #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2102 +/- ##
==========================================
- Coverage 64.88% 64.77% -0.12%
==========================================
Files 208 208
Lines 16458 16482 +24
==========================================
- Hits 10679 10676 -3
- Misses 4451 4477 +26
- Partials 1328 1329 +1
|
HusterWan
reviewed
Aug 21, 2018
test/cli_run_volume_test.go
Outdated
| @@ -331,3 +333,65 @@ func (suite *PouchRunVolumeSuite) TestRunWithDiskQuota(c *check.C) { | |||
|
|
|||
| c.Assert(found, check.Equals, true) | |||
| } | |||
|
|
|||
| // TestRunWithDiskQuota tests running container with --disk-quota. | |||
There was a problem hiding this comment.
%s/TestRunWithDiskQuota/TestRunWithDiskQuotaForLog
HusterWan
reviewed
Aug 21, 2018
|
|
||
| // set container's metadata directory diskquota, for limit the size of container's logs | ||
| metaDir := mgr.Store.Path(c.ID) | ||
| err = quota.SetDiskQuota(metaDir, defaultQuota, newID) |
There was a problem hiding this comment.
rootfs will be set diskquota twice, will it be a problem? just a question
There was a problem hiding this comment.
It is not a problem...
HusterWan
reviewed
Aug 21, 2018
daemon/mgr/container_storage.go
Outdated
| } | ||
|
|
||
| defer func() { | ||
| if ret := mgr.Unmount(ctx, c); ret != nil { |
There was a problem hiding this comment.
can not get the error info when Unmount failed
Add disk quota for container metadata directory, use to limit the size of container's log files. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add disk quota for container metadata directory, use to limit the size
of container's log files.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Added test case
TestRunWithDiskQuotaForLogⅣ. Describe how to verify it
run test case
TestRunWithDiskQuotaForLogⅤ. Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com