feature: add exec resize router #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2105 +/- ##
==========================================
+ Coverage 60.47% 65.12% +4.64%
==========================================
Files 208 208
Lines 16411 16427 +16
==========================================
+ Hits 9925 10698 +773
+ Misses 5296 4402 -894
- Partials 1190 1327 +137
|
allencloud
reviewed
Aug 16, 2018
apis/swagger.yml
Outdated
| description: "bad parameter" | ||
| schema: | ||
| $ref: "#/definitions/Error" | ||
| 500: |
There was a problem hiding this comment.
I think here we have a 404 status code since errors.Wrap(errtypes.ErrNotfound, "exec process "+execid):
// GetExecConfig returns execonfig of a exec process inside container.
func (mgr *ContainerManager) GetExecConfig(ctx context.Context, execid string) (*ContainerExecConfig, error) {
v, ok := mgr.ExecProcesses.Get(execid).Result()
if !ok {
return nil, errors.Wrap(errtypes.ErrNotfound, "exec process "+execid)
}
execConfig, ok := v.(*ContainerExecConfig)
if !ok {
return nil, fmt.Errorf("invalid exec config type")
}
return execConfig, nil
}
fuweid
reviewed
Aug 16, 2018
| @@ -37,15 +38,29 @@ type HistoryResultItem struct { | |||
| // Required: true | |||
| EmptyLayer bool `json:"EmptyLayer"` | |||
|
|
|||
| // ID of every layer image. | |||
There was a problem hiding this comment.
using different type swagger here? 🤔
Signed-off-by: Michael Wan <zirenwan@gmail.com>
|
Any Advice? @allencloud @fuweid 😆 |
fuweid
approved these changes
Aug 21, 2018
|
@fuweid Yes Sir ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
add exec resize router, this api is used by k8s exec
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews