Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix wrong link of pouchd config #2107

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

zjumoon01
Copy link
Contributor

Signed-off-by: Wangrui baijia.wr@antfin.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Wangrui <baijia.wr@antfin.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Wangrui seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @zjumoon01
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

Codecov Report

Merging #2107 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2107      +/-   ##
==========================================
- Coverage   65.14%   65.11%   -0.03%     
==========================================
  Files         208      208              
  Lines       16407    16407              
==========================================
- Hits        10688    10684       -4     
- Misses       4388     4393       +5     
+ Partials     1331     1330       -1
Flag Coverage Δ
#criv1alpha1test 33.14% <ø> (-0.07%) ⬇️
#criv1alpha2test 33.83% <ø> (ø) ⬆️
#integrationtest 39.84% <ø> (-0.04%) ⬇️
#unittest 23.84% <ø> (ø) ⬆️
Impacted Files Coverage Δ
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️
daemon/mgr/system.go 77.68% <0%> (-1.66%) ⬇️
ctrd/image.go 76.75% <0%> (-0.44%) ⬇️
cri/v1alpha1/cri.go 63.66% <0%> (-0.18%) ⬇️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 16, 2018
@allencloud allencloud merged commit 12b4ec3 into AliyunContainerService:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/docs LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants