Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix that list volumes sets hostname as default label filter #2119

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

xiaoxubeii
Copy link
Contributor

Ⅰ. Describe what this PR did

Remove default label filter when list volumes.

Ⅱ. Does this pull request fix one issue?

fixes #2118.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Yes.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xiaoxubeii xiaoxubeii changed the title Fix that list volumes sets hostname as default label filter bugfix: fix that list volumes sets hostname as default label filter Aug 21, 2018
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Aug 21, 2018
@pouchrobot
Copy link
Collaborator

@xiaoxubeii Thanks for your contribution. 🍻
Please sign off in each of your commits.

@codecov-io
Copy link

Codecov Report

Merging #2119 into master will decrease coverage by 4.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2119      +/-   ##
=========================================
- Coverage   64.88%   60.5%   -4.39%     
=========================================
  Files         208     208              
  Lines       16458   16406      -52     
=========================================
- Hits        10679    9926     -753     
- Misses       4451    5293     +842     
+ Partials     1328    1187     -141
Flag Coverage Δ
#criv1alpha1test ?
#criv1alpha2test 34% <ø> (+0.18%) ⬆️
#integrationtest 39.83% <ø> (+0.27%) ⬆️
#unittest 23.91% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
daemon/mgr/volume.go 83.5% <ø> (+1.15%) ⬆️
cri/v1alpha1/cri_types.go 0% <0%> (-100%) ⬇️
cri/v1alpha1/service/cri.go 0% <0%> (-84.62%) ⬇️
cri/v1alpha1/cri_stream.go 0% <0%> (-80%) ⬇️
cri/v1alpha1/server.go 0% <0%> (-79.85%) ⬇️
cri/v1alpha1/cri.go 0% <0%> (-64.14%) ⬇️
cri/v1alpha1/cri_wrapper.go 0% <0%> (-55.81%) ⬇️
cri/criservice.go 39.7% <0%> (-25%) ⬇️
cri/v1alpha1/cri_utils.go 60.58% <0%> (-23.07%) ⬇️
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️
... and 10 more

@rudyfly
Copy link
Collaborator

rudyfly commented Aug 22, 2018

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 22, 2018
@rudyfly rudyfly merged commit 0eed9c4 into AliyunContainerService:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/storage kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Don't need to set hostname as default label when list volume
4 participants