bugfix: can't use sudo command #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2120 +/- ##
==========================================
- Coverage 65.07% 64.96% -0.12%
==========================================
Files 208 208
Lines 16417 16441 +24
==========================================
- Hits 10684 10681 -3
- Misses 4396 4434 +38
+ Partials 1337 1326 -11
|
Ace-Tang
reviewed
Aug 20, 2018
daemon/mgr/container_types.go
Outdated
| } | ||
|
|
||
| // then try lower and upper directory, since overlay filesystem support only. | ||
| logrus.Debugf("GetSpecificBasePath, snapshotter data: (%v)", c.Snapshotter.Data) | ||
| for _, prefixPath := range c.Snapshotter.Data { |
There was a problem hiding this comment.
I think it better to range data from order merged, upper, lower, actually, we just need check merge, but we should avoid if merged directory is not mounted.
fix haven't get additional groups. fix basefs is nil or overlayfs is nil Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
When use ssh connect to container, can't use sudo command, ``` $sudo ls sudo: must be setuid root ``` fix: opencontainers/runc#705 Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
|
LGTM |
pouchrobot
added
the
LGTM
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
When use ssh connect to container, can't use sudo command,
fix: opencontainers/runc#705
fix haven't get additional groups.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
I don't know how to add test case... 😢
You can test it by yourself as below:
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews