Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fail to execute repquota #2123

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Aug 20, 2018

Ⅰ. Describe what this PR did

When fail to execute reqquota, return quota id is 0, instead of
QuotaMinID

Ⅱ. Does this pull request fix one issue?

fixes #2122

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

When fail to execute `reqquota`, return quota id is 0, instead of
`QuotaMinID`

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Aug 20, 2018
@Ace-Tang
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #2123 into master will increase coverage by 4.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2123      +/-   ##
==========================================
+ Coverage   60.47%   64.51%   +4.04%     
==========================================
  Files         208      208              
  Lines       16411    16767     +356     
==========================================
+ Hits         9925    10818     +893     
+ Misses       5296     4604     -692     
- Partials     1190     1345     +155
Flag Coverage Δ
#criv1alpha1test 33.36% <0%> (?)
#criv1alpha2test 33.74% <0%> (-0.15%) ⬇️
#integrationtest 39.82% <0%> (ø) ⬆️
#unittest 23.9% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
storage/quota/quota.go 17.82% <0%> (-0.14%) ⬇️
daemon/mgr/container_utils.go 67.61% <0%> (-15.83%) ⬇️
daemon/mgr/container_types.go 69.35% <0%> (-12.05%) ⬇️
daemon/mgr/container.go 51.97% <0%> (-4.14%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
cri/v1alpha2/cri.go 64.29% <0%> (-0.34%) ⬇️
cri/v1alpha1/cri_utils.go 83.64% <0%> (+23.06%) ⬆️
cri/criservice.go 64.7% <0%> (+24.99%) ⬆️
cri/v1alpha1/cri_wrapper.go 55.8% <0%> (+55.8%) ⬆️
cri/v1alpha1/cri.go 63.79% <0%> (+63.79%) ⬆️
... and 4 more

@Ace-Tang Ace-Tang merged commit 2fa79c5 into AliyunContainerService:master Aug 20, 2018
@rudyfly rudyfly deleted the diskquota-bugfix branch October 29, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pouchd panic
4 participants