test: make Test_mergeEnvSlice test case happy #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Ace-Tang
reviewed
Aug 21, 2018
daemon/mgr/container_utils_test.go
Outdated
| @@ -206,7 +206,7 @@ func Test_mergeEnvSlice(t *testing.T) { | |||
| newEnv: []string{"a=b"}, | |||
| oldEnv: []string{"c=d"}, | |||
| }, | |||
| want: []string{"c=d", "a=b"}, | |||
There was a problem hiding this comment.
I do not advise this way to fix, try to match every value in slice. But consider you have sort before, it also work.
There was a problem hiding this comment.
Agree. we should sort the slice before we check.
Codecov Report
@@ Coverage Diff @@
## master #2131 +/- ##
=========================================
+ Coverage 64.88% 64.9% +0.01%
=========================================
Files 208 208
Lines 16458 16458
=========================================
+ Hits 10679 10682 +3
+ Misses 4451 4449 -2
+ Partials 1328 1327 -1
|
HusterWan
force-pushed
the
zr/fix-testcase
branch
from
3885b4b to
51143a4
Compare
Signed-off-by: Michael Wan <zirenwan@gmail.com>
HusterWan
force-pushed
the
zr/fix-testcase
branch
from
51143a4 to
7668858
Compare
HusterWan
changed the title
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
Now we try TOP(Test-oriented programming), so in order making my test case happy
Just a joke 🤣
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews