bugfix: distinguish NotFound error with others about image #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starnop
force-pushed
the
image-error-not-found
branch
2 times, most recently
from
fc3fdc1 to
fb25945
Compare
|
Please try to use And CI fails, both of the cri-tools testing. |
starnop
changed the title
fuweid
reviewed
Aug 22, 2018
| // TODO: separate ErrImageNotFound with others. | ||
| // Now we just return empty if the error occurred. | ||
| return &runtime.ImageStatusResponse{}, nil | ||
| if errtypes.IsNotfound(err) { |
There was a problem hiding this comment.
why return nil error here? could we check the IsNotfound out of this scope?
There was a problem hiding this comment.
The CRI API declares this :
ImageStatus returns the status of the image. If the image is not present, returns a response with ImageStatusResponse.Image set to nil.
400e7dd to
419de77
Compare
starnop
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2139 +/- ##
==========================================
+ Coverage 64.38% 64.42% +0.03%
==========================================
Files 209 209
Lines 16631 16639 +8
==========================================
+ Hits 10708 10719 +11
+ Misses 4595 4593 -2
+ Partials 1328 1327 -1
|
HusterWan
reviewed
Aug 23, 2018
cri/v1alpha1/cri_utils.go
Outdated
| @@ -18,6 +18,7 @@ import ( | |||
| "github.com/alibaba/pouch/daemon/mgr" | |||
| "github.com/alibaba/pouch/pkg/utils" | |||
|
|
|||
| "github.com/alibaba/pouch/pkg/errtypes" | |||
There was a problem hiding this comment.
pouch own pkg should not put with the third party pakcage
HusterWan
reviewed
Aug 23, 2018
cri/v1alpha2/cri_utils.go
Outdated
| @@ -18,6 +18,7 @@ import ( | |||
| "github.com/alibaba/pouch/daemon/mgr" | |||
| "github.com/alibaba/pouch/pkg/utils" | |||
|
|
|||
| "github.com/alibaba/pouch/pkg/errtypes" | |||
There was a problem hiding this comment.
pouch own pkg should not put with the third party pakcage
fuweid
reviewed
Aug 23, 2018
cri/v1alpha1/cri_utils.go
Outdated
| } | ||
|
|
||
| return nil | ||
| return fmt.Errorf("failed to checkReference sandbox image %q: %v", imageRef, err) |
There was a problem hiding this comment.
I think we should use other word instead of checkReference. how about failed to check sanbox image?
|
LGTM until fix some import sequence. @starnop |
pouchrobot
added
the
LGTM
Signed-off-by: Starnop <starnop@163.com>
starnop
force-pushed
the
image-error-not-found
branch
from
419de77 to
4b63b11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop starnop@163.com
Ⅰ. Describe what this PR did
distinguish NotFound error with others about image
Ⅱ. Does this pull request fix one issue?
None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews