test: make TestRunWithWorkingDir test case happy #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
- Coverage 64.44% 64.41% -0.04%
==========================================
Files 209 209
Lines 16629 16629
==========================================
- Hits 10717 10712 -5
- Misses 4585 4590 +5
Partials 1327 1327
|
fuweid
reviewed
Aug 22, 2018
test/cli_run_working_dir_test.go
Outdated
| res := command.PouchRun("run", "-m", "100m", "-w", dir, "--name", cname, busyboxImage, "pwd") | ||
| // Some Kernel not support Memory, so result information may contains some | ||
| // warning information like: | ||
| // WARNING: Current Kernel does not support memory swap, discard --memory-swap |
There was a problem hiding this comment.
I don't think we should add the -m 100m in this case, because we didn't check the memory. Please remove the comment.
Signed-off-by: Michael Wan <zirenwan@gmail.com>
HusterWan
force-pushed
the
zr/make-test-happy
branch
from
95eb39b to
3614611
Compare
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
fix TestRunWithWorkingDir not success in some specific kernel
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
It is a test case
Ⅳ. Describe how to verify it
TestRunWithWorkingDir passed on all test hosts
Ⅴ. Special notes for reviews
none