style: format cri logs #2147
Merged
style: format cri logs #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
reviewed
Aug 23, 2018
| @@ -33,7 +33,7 @@ func RunCriService(daemonconfig *config.Config, containerMgr mgr.ContainerMgr, i | |||
| err = runv1alpha2(daemonconfig, containerMgr, imageMgr, volumeMgr, readyCh) | |||
| default: | |||
| readyCh <- false | |||
| err = fmt.Errorf("invalid CRI version,failed to start CRI service") | |||
There was a problem hiding this comment.
Please add the specific invalid version number in the error message.
starnop
force-pushed
the
cri-log-format
branch
from
e7ef62c
to
deb375d
Compare
|
I think there should be some rule to guide us:
In the future we will use container-debugger to judge error log, if one day, we will generate more than 1000+ messages, I do not think the debugger-tool would take effect. So, we need to add some guidance for us. @starnop Also cc @fuweid to guide us to have it. |
Signed-off-by: Starnop <starnop@163.com>
starnop
force-pushed
the
cri-log-format
branch
from
deb375d
to
29cba87
Compare
Codecov Report
@@ Coverage Diff @@
## master #2147 +/- ##
==========================================
- Coverage 64.41% 64.37% -0.05%
==========================================
Files 209 209
Lines 16662 16662
==========================================
- Hits 10733 10726 -7
- Misses 4603 4607 +4
- Partials 1326 1329 +3
|
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop starnop@163.com
Ⅰ. Describe what this PR did
Now，we should try to use
failed to do somethingandsuccess to do somethingwhen constructing error or log.Ⅱ. Does this pull request fix one issue?
None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews