feature: add cgroupfs in Info API #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ace-Tang
reviewed
Aug 23, 2018
daemon/config/config.go
Outdated
| // current pouchd only supports directly managing cgroupfs. | ||
| // TODO: add 'systemd' to make systemd manage cgroupfs rather than directly using it. | ||
| // In the future we will support this config in the daemon configuration. | ||
| return "cgroupfs" |
There was a problem hiding this comment.
Now we only support cgroupfs, systemd may put into consider, can you try to get this type from somewhere?
There was a problem hiding this comment.
can you try to get this type from somewhere
Could you explain a little bit more about the above sentence? @Ace-Tang Thanks a lot.
There was a problem hiding this comment.
Not hardcode cgroup driver.
There was a problem hiding this comment.
OK, I see. Thanks a lot.
Codecov Report
@@ Coverage Diff @@
## master #2148 +/- ##
==========================================
- Coverage 64.31% 62.56% -1.76%
==========================================
Files 209 209
Lines 16664 17579 +915
==========================================
+ Hits 10718 10998 +280
- Misses 4614 5208 +594
- Partials 1332 1373 +41
|
|
/LGTM |
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
allencloud
force-pushed
the
add-cgroup-driver
branch
from
2859bff
to
44d2080
Compare
|
Ping @Ace-Tang |
|
lgtm |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
add cgroupfs in Info API.
current pouchd only supports directly managing cgroupfs. In the future we will support this config in the daemon configuration.
TODO: add 'systemd' to make systemd manage cgroupfs rather than directly using it.
Ⅱ. Does this pull request fix one issue?
fix #2143
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
added in integraion test.
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none