Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: handle the error returned by SandboxStore.Put #2151

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

starnop
Copy link
Contributor

@starnop starnop commented Aug 23, 2018

Signed-off-by: Starnop starnop@163.com

Ⅰ. Describe what this PR did

handle the error returned by SandboxStore.Put

Ⅱ. Does this pull request fix one issue?

None.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Aug 23, 2018
Signed-off-by: Starnop <starnop@163.com>
@codecov-io
Copy link

Codecov Report

Merging #2151 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2151      +/-   ##
==========================================
- Coverage   64.41%   64.37%   -0.05%     
==========================================
  Files         209      209              
  Lines       16662    16664       +2     
==========================================
- Hits        10733    10727       -6     
- Misses       4603     4607       +4     
- Partials     1326     1330       +4
Flag Coverage Δ
#criv1alpha1test 32.98% <0%> (-0.01%) ⬇️
#criv1alpha2test 33.38% <0%> (-0.18%) ⬇️
#integrationtest 39.25% <0%> (-0.01%) ⬇️
#unittest 23.85% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
cri/v1alpha1/cri.go 63.71% <0%> (-0.29%) ⬇️
cri/v1alpha2/cri.go 63.68% <0%> (-0.61%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️

@allencloud
Copy link
Collaborator

LGTM

@allencloud allencloud merged commit 5c0e9a6 into AliyunContainerService:master Aug 23, 2018
@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants