config: remove check unknown flag in config file #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. daemon config come from two part, one is command flag, the other is from config file, but the flags from two part can not keep consistent，so remove unknow flags check. 2. flatten 'key-value' in config file, check flags conflict between command line and file. Signed-off-by: Ace-Tang <aceapril@126.com>
Codecov Report
@@ Coverage Diff @@
## master #2161 +/- ##
==========================================
- Coverage 64.41% 64.35% -0.07%
==========================================
Files 209 209
Lines 16669 16659 -10
==========================================
- Hits 10738 10721 -17
- Misses 4603 4607 +4
- Partials 1328 1331 +3
|
HusterWan
reviewed
Aug 27, 2018
| @@ -182,23 +182,6 @@ func (suite *PouchDaemonSuite) TestDaemonSliceFlagNotConflict(c *check.C) { | |||
| c.Assert(err, check.IsNil) | |||
| } | |||
|
|
|||
| // TestDaemonConfigFileUnknownFlag tests start daemon with unknown flags in configure file. | |||
| func (suite *PouchDaemonSuite) TestDaemonConfigFileUnknownFlag(c *check.C) { | |||
There was a problem hiding this comment.
Why delete this test case ?
|
LGTM |
pouchrobot
added
the
LGTM
allencloud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is from config file, but the flags from two part can not keep
consistent，so remove unknow flags check.
command line and file.
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews