refactor: delete update specific code #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Wan <zirenwan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2165 +/- ##
==========================================
+ Coverage 64.3% 64.46% +0.16%
==========================================
Files 209 209
Lines 16693 16690 -3
==========================================
+ Hits 10735 10760 +25
+ Misses 4618 4600 -18
+ Partials 1340 1330 -10
|
allencloud
reviewed
Aug 27, 2018
| @@ -1020,6 +1006,12 @@ func (mgr *ContainerManager) Update(ctx context.Context, name string, config *ty | |||
| } | |||
| c.Config.Env = newEnvSlice | |||
|
|
|||
| if mgr.containerPlugin != nil { | |||
| if err = mgr.containerPlugin.PostUpdate(c.BaseFS, c.Config.Env); err != nil { | |||
| return err | |||
There was a problem hiding this comment.
Do we have a rule to record the error log in the caller's code or the implementation part? @HusterWan
There was a problem hiding this comment.
Yes, we will record the error log in the end of api.
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
updating container will also update a Label
DiskQuota, this is not a common action that just is for compatible with situation in alibaba. so i will delete this part, and move the operation toPreUpatehookⅡ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
yes
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none