test: install criu in ci test #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this pr after I release alibaba/runc version v1.0.0-rc4-2. |
fuweid
reviewed
Aug 30, 2018
| if [[ "${os_dist}" = "Ubuntu" ]]; then | ||
| criu::ubuntu::install_dependencies > /dev/null | ||
| criu::ubuntu::install > /dev/null | ||
| fi |
There was a problem hiding this comment.
If fails here, all test will stop and fail.
fuweid
reviewed
Aug 30, 2018
hack/install/install_criu.sh
Outdated
|
|
||
| # criu::ubuntu::install will install criu from source. | ||
| criu::ubuntu::install() { | ||
| local tmpdir branch |
There was a problem hiding this comment.
remove the branch if it is useless
install criu brfore ci test begin, update runc version to v1.0.0-rc4-2 to enable checkpoint/restore function. Uncomment start from checkpoint test case. Signed-off-by: Ace-Tang <aceapril@126.com>
Codecov Report
@@ Coverage Diff @@
## master #2175 +/- ##
==========================================
+ Coverage 64.34% 64.97% +0.63%
==========================================
Files 209 209
Lines 16739 16739
==========================================
+ Hits 10770 10876 +106
+ Misses 4635 4515 -120
- Partials 1334 1348 +14
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
install criu brfore ci test begin, update runc version to v1.0.0-rc4-2
to enable checkpoint/restore function. Uncomment start from checkpoint
test case.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews