Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: General availability #2184

Merged
merged 1 commit into from
Aug 31, 2018
Merged

release: General availability #2184

merged 1 commit into from
Aug 31, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Aug 31, 2018

We run PouchContainer for a while and service/functionality becomes more
and more stable. Thanks for all the contributors. It's time to release
the GA version.

Signed-off-by: Wei Fu fhfuwei@163.com

Ⅰ. Describe what this PR did

Release

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

No need

Ⅳ. Describe how to verify it

CI

Ⅴ. Special notes for reviews

We run PouchContainer for a while and service/functionality becomes more
and more stable. Thanks for all the contributors. It's time to release
the GA version.

Signed-off-by: Wei Fu <fhfuwei@163.com>
@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 31, 2018
@allencloud allencloud merged commit be1ae7b into AliyunContainerService:master Aug 31, 2018
@codecov-io
Copy link

Codecov Report

Merging #2184 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2184      +/-   ##
==========================================
+ Coverage   64.84%   64.99%   +0.14%     
==========================================
  Files         209      209              
  Lines       16739    16739              
==========================================
+ Hits        10855    10880      +25     
+ Misses       4527     4513      -14     
+ Partials     1357     1346      -11
Flag Coverage Δ
#criv1alpha1test 32.9% <ø> (+0.21%) ⬆️
#criv1alpha2test 33.58% <ø> (+0.13%) ⬆️
#integrationtest 39.96% <ø> (+0.04%) ⬆️
#unittest 23.95% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/v1alpha2/cri.go 63.66% <0%> (+0.32%) ⬆️
cri/v1alpha1/cri.go 62.95% <0%> (+0.34%) ⬆️
daemon/mgr/container.go 56.98% <0%> (+0.61%) ⬆️
daemon/mgr/container_utils.go 84.33% <0%> (+1.2%) ⬆️
ctrd/container.go 53.82% <0%> (+1.43%) ⬆️
pkg/meta/store.go 64.06% <0%> (+1.56%) ⬆️
ctrd/watch.go 80.3% <0%> (+7.57%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants