Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a document about CRI API #2247

Merged
merged 3 commits into from
Sep 21, 2018

Conversation

starnop
Copy link
Contributor

@starnop starnop commented Sep 17, 2018

Ⅰ. Describe what this PR did

For the better delivery of the CRI of PouchContainer, one ducument of apis of CRI Manager is needed. And for the future, scripts were written to automate this work which can be integrate into the project pouchrobot.

Ⅱ. Does this pull request fix one issue?

None.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Only scripts and documents are involved

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

By the way, I update the file api.pb.go by via script bash hack/protoc/protoc.sh gen_proto

@allencloud allencloud changed the title docs : add a document about CRI API docs: add a document about CRI API Sep 17, 2018
Signed-off-by: Starnop <starnop@163.com>
Signed-off-by: Starnop <starnop@163.com>
Signed-off-by: Starnop <starnop@163.com>
@starnop
Copy link
Contributor Author

starnop commented Sep 17, 2018

@allencloud @fuweid @YaoZengzeng PTAL. Thanks. ^_^

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Sep 21, 2018
@allencloud allencloud merged commit 4f6d986 into AliyunContainerService:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/docs LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants