feature: support RunAsGroup of CRI Manager #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2263 +/- ##
==========================================
+ Coverage 66.71% 66.88% +0.16%
==========================================
Files 208 208
Lines 16937 16954 +17
==========================================
+ Hits 11299 11339 +40
+ Misses 4270 4257 -13
+ Partials 1368 1358 -10
|
|
@YaoZengzeng @fuweid PTAL. Thanks. ^0^ |
|
Please help to take a review for this, thanks. @YaoZengzeng |
YaoZengzeng
reviewed
Sep 27, 2018
cri/v1alpha2/cri_utils.go
Outdated
| @@ -205,14 +205,20 @@ func applySandboxSecurityContext(lc *runtime.LinuxPodSandboxConfig, config *apit | |||
| sc = &runtime.LinuxContainerSecurityContext{ | |||
| SupplementalGroups: lc.SecurityContext.SupplementalGroups, | |||
| RunAsUser: lc.SecurityContext.RunAsUser, | |||
| RunAsGroup: lc.SecurityContext.RunAsGroup, | |||
| RunAsUsername: "", | |||
There was a problem hiding this comment.
If RunAsUsername is "", don't need to initialize it. Its default value is "".
|
Except the minor issue above, LGTM |
Signed-off-by: Starnop <starnop@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop starnop@163.com
Ⅰ. Describe what this PR did
In the version
v1alpha2of CRI defined by Kubernetes,RunAsGroupis supported. We should also support it for compatibility.Ⅱ. Does this pull request fix one issue?
None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Has updated the test cases.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Please refer to : https://github.com/kubernetes/kubernetes/blob/d1111a57d9243c55e02e0e66af55c2ddb36f3767/pkg/kubelet/apis/cri/runtime/v1alpha2/api.pb.go#L566