bugfix: complete json tag for StreamServerReusePort and add some useful log for stop & remove pod operation #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2266 +/- ##
==========================================
+ Coverage 66.72% 66.77% +0.05%
==========================================
Files 208 208
Lines 16926 16932 +6
==========================================
+ Hits 11294 11307 +13
+ Misses 4267 4262 -5
+ Partials 1365 1363 -2
|
YaoZengzeng
force-pushed
the
bug-log
branch
from
1bf14f0 to
fc776f3
Compare
YaoZengzeng
force-pushed
the
bug-log
branch
from
fc776f3 to
667fdd4
Compare
starnop
reviewed
Sep 21, 2018
cri/v1alpha1/cri.go
Outdated
| @@ -394,6 +397,7 @@ func (c *CriManager) RemovePodSandbox(ctx context.Context, r *runtime.RemovePodS | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to remove container %q of sandbox %q: %v", container.ID, podSandboxID, err) | |||
| } | |||
| logrus.Infof("successfully remove container %q of sandbox %q", container.ID, podSandboxID) | |||
There was a problem hiding this comment.
Maybe "success to do something" will be better? ^_^
log for stop & remove pod operation Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
YaoZengzeng
force-pushed
the
bug-log
branch
from
667fdd4 to
7e18e53
Compare
allencloud
reviewed
Sep 21, 2018
| @@ -329,6 +329,7 @@ func (c *CriManager) StopPodSandbox(ctx context.Context, r *runtime.StopPodSandb | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to stop container %q of sandbox %q: %v", container.ID, podSandboxID, err) | |||
| } | |||
| logrus.Infof("success to stop container %q of sandbox %q", container.ID, podSandboxID) | |||
There was a problem hiding this comment.
Maybe debug is sufficient.
allencloud
reviewed
Sep 21, 2018
| @@ -394,6 +397,7 @@ func (c *CriManager) RemovePodSandbox(ctx context.Context, r *runtime.RemovePodS | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to remove container %q of sandbox %q: %v", container.ID, podSandboxID, err) | |||
| } | |||
| logrus.Infof("success remove container %q of sandbox %q", container.ID, podSandboxID) | |||
There was a problem hiding this comment.
Same issue. Do you think so?
There was a problem hiding this comment.
Hmm... I think maybe Infof is more suitable
The operation of stop and remove is not as frequent as list
It's helpful and important for us to know details of every pod related operation 😂
There was a problem hiding this comment.
OK， just double check.
|
LGTM, waiting for ci passed. |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
complete the missing json tag for
StreamServerReusePortadd some useful logs for stop & remove pod which may have multiple containers
failed to log
createErrⅡ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
No
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews