Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix check annotation format #2267

Merged
merged 1 commit into from
Sep 21, 2018
Merged

bugfix: fix check annotation format #2267

merged 1 commit into from
Sep 21, 2018

Conversation

Ace-Tang
Copy link
Contributor

@Ace-Tang Ace-Tang commented Sep 21, 2018

fix format check in annotation, allow '=' in value.

Signed-off-by: Ace-Tang aceapril@126.com

Ⅰ. Describe what this PR did

allow pouch run --annotation a="b=c", this format shoule be allowed, '=' is not a invalid charactor.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

add unit test.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

fix format check in annotation, allow '=' in value.

Signed-off-by: Ace-Tang <aceapril@126.com>
@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #2267 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2267      +/-   ##
==========================================
+ Coverage   66.72%   66.82%   +0.09%     
==========================================
  Files         208      208              
  Lines       16926    16926              
==========================================
+ Hits        11294    11310      +16     
+ Misses       4267     4257      -10     
+ Partials     1365     1359       -6
Flag Coverage Δ
#criv1alpha1test 32.5% <0%> (ø) ⬆️
#criv1alpha2test 36.12% <0%> (+0.15%) ⬆️
#integrationtest 39.57% <0%> (-0.02%) ⬇️
#nodee2etest 33.46% <0%> (+0.06%) ⬆️
#unittest 23.77% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
apis/opts/spec_annotation.go 100% <100%> (+25%) ⬆️
daemon/mgr/snapshot.go 89.85% <0%> (-4.35%) ⬇️
daemon/mgr/container.go 57.59% <0%> (+0.4%) ⬆️
ctrd/container.go 60.23% <0%> (+1.9%) ⬆️
daemon/containerio/cri_log_file.go 88.23% <0%> (+3.92%) ⬆️
ctrd/watch.go 80.3% <0%> (+4.54%) ⬆️

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Sep 21, 2018
@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Sep 21, 2018
@allencloud allencloud merged commit 4e47fda into AliyunContainerService:master Sep 21, 2018
@Ace-Tang Ace-Tang deleted the fix_opt_check branch September 27, 2018 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants