bugfix: use same memory in ringbuffer #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2268 +/- ##
==========================================
- Coverage 66.72% 58.81% -7.91%
==========================================
Files 208 208
Lines 16926 17340 +414
==========================================
- Hits 11294 10199 -1095
- Misses 4267 5638 +1371
- Partials 1365 1503 +138
|
ContainerIO' backend will read data into ringbuffer. But the data blocks use the same memory so that the comming data will override the previous one. Need to copy data before push into ringbuffer. Signed-off-by: Wei Fu <fuweid89@gmail.com>
Ace-Tang
reviewed
Sep 21, 2018
| // If we don't copy the data and the previous data isn't consumed by | ||
| // ringbuf pop action, the incoming data will override the previous data | ||
| // in the ringbuf. | ||
| copyData := make([]byte, n) |
There was a problem hiding this comment.
From the comment, Copy make data not be override, right?
There was a problem hiding this comment.
More qeustion, as I do not know all ringbuf logic. The data will always append if pop not assume?
There was a problem hiding this comment.
yes. if the size reaches the capacity, ringbuffer will drop the old one.
|
LGTM |
pouchrobot
added
the
LGTM
|
LGTM as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Fu fuweid89@gmail.com
Ⅰ. Describe what this PR did
ContainerIO' backend will read data into ringbuffer. But the data blocks
use the same memory so that the comming data will override the previous
one.
Ⅱ. Does this pull request fix one issue?
When the input is too long, ContainerIO will separate one line into two data blocks. But the blocks shares the same memory, the new one will override the old one, like
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Added
Ⅳ. Describe how to verify it
input >128 chars
Ⅴ. Special notes for reviews
I hate the pattern...