-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove redundant code #2285
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2285 +/- ##
==========================================
+ Coverage 66.71% 66.71% +<.01%
==========================================
Files 208 208
Lines 16937 16934 -3
==========================================
- Hits 11299 11298 -1
Misses 4270 4270
+ Partials 1368 1366 -2
|
@SimonCqk Thanks for your contribution. 🍻 |
We found this is your first time to contribute to Pouch, @SimonCqk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code. And I did not see any side effect brought by the update. WDYT? @fuweid
Thanks a lot for your contribution. Could you also help sign the CLA? @SimonCqk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews