Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant code #2285

Merged
merged 1 commit into from
Sep 29, 2018

Conversation

SimonCqk
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Sep 29, 2018

Codecov Report

Merging #2285 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2285      +/-   ##
==========================================
+ Coverage   66.71%   66.71%   +<.01%     
==========================================
  Files         208      208              
  Lines       16937    16934       -3     
==========================================
- Hits        11299    11298       -1     
  Misses       4270     4270              
+ Partials     1368     1366       -2
Flag Coverage Δ
#criv1alpha1test 32.63% <0%> (+0.02%) ⬆️
#criv1alpha2test 35.93% <100%> (-0.04%) ⬇️
#integrationtest 39.54% <100%> (+0.04%) ⬆️
#nodee2etest 33.27% <0%> (+0.01%) ⬆️
#unittest 23.75% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pkg/kmutex/kmutex.go 92.18% <100%> (-0.35%) ⬇️
ctrd/container.go 59.76% <0%> (-0.48%) ⬇️
cri/v1alpha2/cri_wrapper.go 61.2% <0%> (ø) ⬆️
cri/v1alpha2/cri.go 66.17% <0%> (ø) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
daemon/containerio/cri_log_file.go 88.23% <0%> (+3.92%) ⬆️

@pouchrobot
Copy link
Collaborator

@SimonCqk Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @SimonCqk
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@allencloud allencloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code. And I did not see any side effect brought by the update. WDYT? @fuweid

@allencloud
Copy link
Collaborator

Thanks a lot for your contribution. Could you also help sign the CLA? @SimonCqk
image

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allencloud allencloud merged commit 8be6286 into AliyunContainerService:master Sep 29, 2018
@allencloud allencloud changed the title remove redundant code. refactor: remove redundant code Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants