test: modify network test #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify network test, and more time to check the port mapping is successful. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2312 +/- ##
==========================================
+ Coverage 62.66% 67.25% +4.59%
==========================================
Files 213 213
Lines 17464 17473 +9
==========================================
+ Hits 10943 11752 +809
+ Misses 5271 4323 -948
- Partials 1250 1398 +148
|
allencloud
reviewed
Oct 15, 2018
| err := icmd.RunCommand("timeout", "5", "curl", "localhost:9999").Compare(expct) | ||
| c.Assert(err, check.IsNil) | ||
| success := false | ||
| for i := 0; i < 60; i++ { |
There was a problem hiding this comment.
This will try 60 times?
Will it be so long?
Just double check. @zhuangqh
There was a problem hiding this comment.
Often, this command would success in several tries. Try many times to make sure the network port mapping is fail....longest timeout is 6 minutes.
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com
Ⅰ. Describe what this PR did
modify network test, and more time to check the port mapping is
successful.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
modified
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews