Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add volume plugin #2317

Merged

Conversation

zhuangqh
Copy link
Contributor

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

Ⅰ. Describe what this PR did

Add volume plugin

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Add volume plugin

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #2317 into master will increase coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2317      +/-   ##
==========================================
+ Coverage    67.2%   67.31%   +0.11%     
==========================================
  Files         213      213              
  Lines       17511    17518       +7     
==========================================
+ Hits        11769    11793      +24     
+ Misses       4341     4329      -12     
+ Partials     1401     1396       -5
Flag Coverage Δ
#criv1alpha1test 32.2% <0%> (-0.07%) ⬇️
#criv1alpha2test 36.11% <0%> (-0.06%) ⬇️
#integrationtest 40.12% <0%> (+0.06%) ⬆️
#nodee2etest 33.65% <0%> (+0.04%) ⬆️
#unittest 23.19% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
daemon/daemon.go 56.25% <0%> (-2.13%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
cri/v1alpha1/cri.go 60.7% <0%> (-0.33%) ⬇️
cri/v1alpha2/cri.go 68.85% <0%> (-0.25%) ⬇️
daemon/mgr/container.go 57.93% <0%> (+0.2%) ⬆️
daemon/containerio/container_io.go 75.95% <0%> (+1.09%) ⬆️
ctrd/image.go 78.94% <0%> (+2.19%) ⬆️
daemon/mgr/container_utils.go 84.33% <0%> (+3.61%) ⬆️
pkg/meta/store.go 64.06% <0%> (+3.9%) ⬆️
daemon/containerio/cri_log_file.go 88.23% <0%> (+3.92%) ⬆️
... and 2 more

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 9ce0a62 into AliyunContainerService:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants