-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: auto generate pouch cli/api docs via code #2322
docs: auto generate pouch cli/api docs via code #2322
Conversation
Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>
Codecov Report
@@ Coverage Diff @@
## master #2322 +/- ##
=========================================
+ Coverage 65.95% 66.9% +0.94%
=========================================
Files 217 218 +1
Lines 17652 17943 +291
=========================================
+ Hits 11642 12004 +362
+ Misses 4631 4522 -109
- Partials 1379 1417 +38
|
@@ -4,88 +4,27 @@ Upgrade a container with new image and args | |||
|
|||
### Synopsis | |||
|
|||
Upgrade a container with new image and args | |||
upgrade is a feature to replace a container's image.You can specify the new Entrypoint and Cmd for the new container. When you want to updatea container's image, but inherit the network and volumes of the old container, then you shouldthink about the upgrade feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a typo: When you want to updatea container's **
should be update a
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. Since this is an auto-generated pull request. Could you please help to fix the source doc of https://github.com/alibaba/pouch/blob/master/cli/upgrade.go#L15 to add a white space?6 This could be done via your new pull request. @lyn716
var upgradeDescription = "upgrade is a feature to replace a container's image." +
"You can specify the new Entrypoint and Cmd for the new container. When you want to update" +
"a container's image, but inherit the network and volumes of the old container, then you should" +
"think about the upgrade feature."
LGTM, merge this. |
Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com
1.Describe what this PR did
This PR is automatically done by AI-based collaborating robot.
Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.
2.Does this pull request fix one issue?
None
3.Describe how you did it
First, execute command "make client" to build new pouch cli;
Second, execute command "./pouch gen-doc" to generate new cli docs.
For API part, we use a tool swagger2markup to make it.
4.Describe how to verify it
None
5.Special notes for reviews
The cli/api doc must be automatically generated.