Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: auto generate pouch cli/api docs via code #2322

Merged

Conversation

pouchrobot
Copy link
Collaborator

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did
This PR is automatically done by AI-based collaborating robot.
Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue?
None

3.Describe how you did it
First, execute command "make client" to build new pouch cli;
Second, execute command "./pouch gen-doc" to generate new cli docs.

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it
None

5.Special notes for reviews
The cli/api doc must be automatically generated.

Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>
@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #2322 into master will increase coverage by 0.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2322      +/-   ##
=========================================
+ Coverage   65.95%   66.9%   +0.94%     
=========================================
  Files         217     218       +1     
  Lines       17652   17943     +291     
=========================================
+ Hits        11642   12004     +362     
+ Misses       4631    4522     -109     
- Partials     1379    1417      +38
Flag Coverage Δ
#criv1alpha1test 32.06% <ø> (-0.19%) ⬇️
#criv1alpha2test 36.39% <ø> (?)
#integrationtest 40.43% <ø> (+0.02%) ⬆️
#nodee2etest 33.5% <ø> (-0.09%) ⬇️
#unittest 23.27% <ø> (ø) ⬆️
Impacted Files Coverage Δ
ctrd/container_lock.go 77.41% <0%> (-22.59%) ⬇️
cri/ocicni/cni_manager.go 59.18% <0%> (-12.25%) ⬇️
apis/server/exec_bridge.go 38.96% <0%> (-11.89%) ⬇️
daemon/mgr/container_utils.go 77.2% <0%> (-7.13%) ⬇️
ctrd/container.go 51.92% <0%> (-6.41%) ⬇️
cri/v1alpha1/cri.go 60.38% <0%> (-0.33%) ⬇️
apis/server/log_filter_writer.go 0% <0%> (ø)
daemon/mgr/container.go 59% <0%> (+0.43%) ⬆️
daemon/containerio/container_io.go 75.95% <0%> (+1.09%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
... and 10 more

@@ -4,88 +4,27 @@ Upgrade a container with new image and args

### Synopsis

Upgrade a container with new image and args
upgrade is a feature to replace a container's image.You can specify the new Entrypoint and Cmd for the new container. When you want to updatea container's image, but inherit the network and volumes of the old container, then you shouldthink about the upgrade feature.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a typo: When you want to updatea container's ** should be update a.

Copy link
Collaborator

@allencloud allencloud Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. Since this is an auto-generated pull request. Could you please help to fix the source doc of https://github.com/alibaba/pouch/blob/master/cli/upgrade.go#L15 to add a white space?6 This could be done via your new pull request. @lyn716

var upgradeDescription = "upgrade is a feature to replace a container's image." +
	"You can specify the new Entrypoint and Cmd for the new container. When you want to update" +
	"a container's image, but inherit the network and volumes of the old container, then you should" +
	"think about the upgrade feature."

@allencloud
Copy link
Collaborator

LGTM, merge this.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Oct 18, 2018
@allencloud allencloud merged commit b2542f1 into AliyunContainerService:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/docs LGTM one maintainer or community participant agrees to merge the pull reuqest. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants