-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: api_runtime_test: add new checkpoints #2329
Merged
zhuangqh
merged 1 commit into
AliyunContainerService:master
from
chuanchang:add_runtime_test
Dec 28, 2018
Merged
test: api_runtime_test: add new checkpoints #2329
zhuangqh
merged 1 commit into
AliyunContainerService:master
from
chuanchang:add_runtime_test
Dec 28, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2329 +/- ##
==========================================
+ Coverage 68.9% 69.13% +0.22%
==========================================
Files 279 279
Lines 18834 18834
==========================================
+ Hits 12978 13020 +42
+ Misses 4386 4342 -44
- Partials 1470 1472 +2
|
fuweid
reviewed
Oct 23, 2018
Ace-Tang
suggested changes
Oct 23, 2018
chuanchang
force-pushed
the
add_runtime_test
branch
from
December 27, 2018 05:52
761dc50
to
7008684
Compare
missing the test for |
Signed-off-by: Alex Jia <chuanchang.jia@gmail.com>
chuanchang
force-pushed
the
add_runtime_test
branch
from
December 27, 2018 12:42
7008684
to
9633324
Compare
Done |
zhuangqh
approved these changes
Dec 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new checkpoints into runtime testing.
Signed-off-by: Alex Jia chuanchang.jia@gmail.com
Ⅰ. Describe what this PR did
As summary.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
go test
Ⅴ. Special notes for reviews