Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: api_runtime_test: add new checkpoints #2329

Merged
merged 1 commit into from
Dec 28, 2018

Conversation

chuanchang
Copy link
Contributor

Add new checkpoints into runtime testing.

Signed-off-by: Alex Jia chuanchang.jia@gmail.com

Ⅰ. Describe what this PR did

As summary.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

go test

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #2329 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2329      +/-   ##
==========================================
+ Coverage    68.9%   69.13%   +0.22%     
==========================================
  Files         279      279              
  Lines       18834    18834              
==========================================
+ Hits        12978    13020      +42     
+ Misses       4386     4342      -44     
- Partials     1470     1472       +2
Flag Coverage Δ
#criv1alpha1test 31.28% <ø> (-0.15%) ⬇️
#criv1alpha2test 35.71% <ø> (+0.14%) ⬆️
#integrationtest 41.18% <ø> (+0.12%) ⬆️
#nodee2etest 32.71% <ø> (-0.05%) ⬇️
#unittest 26.93% <ø> (+0.14%) ⬆️
Impacted Files Coverage Δ
cri/v1alpha2/cri_wrapper.go 64.4% <0%> (-2.4%) ⬇️
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
cri/v1alpha1/cri.go 59.43% <0%> (-0.67%) ⬇️
daemon/mgr/container_utils.go 83.92% <0%> (-0.6%) ⬇️
daemon/mgr/container.go 58.79% <0%> (ø) ⬆️
cri/v1alpha2/cri.go 67.57% <0%> (+0.12%) ⬆️
ctrd/client.go 70.46% <0%> (+2.01%) ⬆️
daemon/mgr/events.go 100% <0%> (+3.7%) ⬆️
daemon/mgr/system.go 73.28% <0%> (+5.34%) ⬆️
ctrd/watch.go 84.5% <0%> (+7.04%) ⬆️
... and 4 more

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2018

CLA assistant check
All committers have signed the CLA.

apis/opts/config/runtime.go Outdated Show resolved Hide resolved
apis/opts/config/runtime.go Outdated Show resolved Hide resolved
@chuanchang
Copy link
Contributor Author

chuanchang commented Dec 27, 2018

@Ace-Tang @fuweid I have removed String() related testing according to @zhuangqh 's advise.

@zhuangqh
Copy link
Contributor

missing the test for Type() interface? @chuanchang

Signed-off-by: Alex Jia <chuanchang.jia@gmail.com>
@chuanchang
Copy link
Contributor Author

missing the test for Type() interface? @chuanchang

Done

Copy link
Contributor

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants