test: api_network_test: add new check points #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2349 +/- ##
==========================================
+ Coverage 66.57% 68.15% +1.57%
==========================================
Files 265 265
Lines 18209 18236 +27
==========================================
+ Hits 12123 12428 +305
+ Misses 4682 4380 -302
- Partials 1404 1428 +24
|
|
|
chuanchang
force-pushed
the
add_network_test
branch
3 times, most recently
from
5013265 to
caf69f4
Compare
fuweid
reviewed
Oct 23, 2018
| @@ -94,7 +95,8 @@ func ValidateNetworks(nwConfig *types.NetworkingConfig) error { | |||
| for k := range nwConfig.EndpointsConfig { | |||
| l = append(l, k) | |||
| } | |||
|
|
|||
| // make sure l is sorted | |||
| sort.Strings(l) | |||
There was a problem hiding this comment.
the same questions to previous ulimit testing ...
Signed-off-by: Alex Jia <chuanchang.jia@gmail.com>
chuanchang
force-pushed
the
add_network_test
branch
from
caf69f4 to
d8a663d
Compare
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As summary.
Signed-off-by: Alex Jia chuanchang.jia@gmail.com
Ⅰ. Describe what this PR did
As summary.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
go test
Ⅴ. Special notes for reviews