Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: get ip address by hostname -i #2367

Merged
merged 2 commits into from
Oct 31, 2018

Conversation

zhuangqh
Copy link
Contributor

Ⅰ. Describe what this PR did

Get ip address by hostname -i if there is no default route, or fail to initialize the cri of pouchd.
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

get ip address by `hostname -i`, in alibaba server, these is no default route,
so when enable pouch-cri, it can't ip address by default route to initialize the cri of pouchd.
 Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #2367 into master will decrease coverage by 1.38%.
The diff coverage is 10.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2367      +/-   ##
==========================================
- Coverage   68.08%   66.69%   -1.39%     
==========================================
  Files         265      280      +15     
  Lines       18210    19118     +908     
==========================================
+ Hits        12398    12751     +353     
- Misses       4390     4908     +518     
- Partials     1422     1459      +37
Flag Coverage Δ
#criv1alpha1test 31.58% <10.52%> (-0.03%) ⬇️
#criv1alpha2test 35.8% <10.52%> (+0.31%) ⬆️
#integrationtest 39.54% <0%> (-0.01%) ⬇️
#nodee2etest 33.19% <10.52%> (+0.07%) ⬆️
#unittest 25.49% <0%> (+0.18%) ⬆️
Impacted Files Coverage Δ
pkg/netutils/interface.go 88.94% <10.52%> (-6.9%) ⬇️
cri/v1alpha2/cri_types.go 50% <0%> (-50%) ⬇️
cri/v1alpha2/cri.go 48.37% <0%> (-19.95%) ⬇️
cri/criservice.go 45.71% <0%> (-10.24%) ⬇️
daemon/config/config.go 39.28% <0%> (-8.66%) ⬇️
cri/v1alpha2/cri_utils.go 85% <0%> (-5.86%) ⬇️
daemon/mgr/snapshot.go 89.85% <0%> (-4.35%) ⬇️
daemon/mgr/events.go 96.29% <0%> (-3.71%) ⬇️
ctrd/client.go 66.92% <0%> (-2.31%) ⬇️
daemon/mgr/container_validation.go 44.37% <0%> (-1.33%) ⬇️
... and 23 more

@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels Oct 26, 2018
@zhuangqh zhuangqh requested a review from rudyfly October 26, 2018 13:18
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
@rudyfly
Copy link
Collaborator

rudyfly commented Oct 31, 2018

LGTM

@rudyfly rudyfly merged commit 7006be4 into AliyunContainerService:master Oct 31, 2018
@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants