Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update issue templates #2376

Merged
merged 1 commit into from
Oct 29, 2018
Merged

docs: Update issue templates #2376

merged 1 commit into from
Oct 29, 2018

Conversation

allencloud
Copy link
Collaborator

The github have already support different issue template. I added three:

  • bug report
  • feature request
  • questions about PouchContainer

The github have already support different issue template. I added three:

* bug report
* feature request
* questions about PouchContainer
@codecov
Copy link

codecov bot commented Oct 28, 2018

Codecov Report

Merging #2376 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2376      +/-   ##
==========================================
- Coverage   68.37%   68.34%   -0.03%     
==========================================
  Files         265      265              
  Lines       18211    18211              
==========================================
- Hits        12452    12447       -5     
- Misses       4347     4349       +2     
- Partials     1412     1415       +3
Flag Coverage Δ
#criv1alpha1test 31.67% <ø> (+0.04%) ⬆️
#criv1alpha2test 35.66% <ø> (-0.08%) ⬇️
#integrationtest 39.59% <ø> (ø) ⬆️
#nodee2etest 33.13% <ø> (-0.07%) ⬇️
#unittest 25.52% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/v1alpha2/cri_wrapper.go 63.6% <0%> (-1.2%) ⬇️
cri/v1alpha2/cri.go 69.04% <0%> (-0.49%) ⬇️
daemon/mgr/container.go 59.17% <0%> (ø) ⬆️
ctrd/container.go 59.76% <0%> (+0.47%) ⬆️

@pouchrobot
Copy link
Collaborator

@allencloud Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Oct 29, 2018
@allencloud allencloud removed the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Oct 29, 2018
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 17eb976 into master Oct 29, 2018
@allencloud allencloud deleted the allencloud-patch-1 branch October 31, 2018 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants