feature: replace downloading k8s components from googleapis in allinone with apt from aliyun mirrors #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2402 +/- ##
==========================================
+ Coverage 68.45% 68.48% +0.02%
==========================================
Files 275 275
Lines 18291 18278 -13
==========================================
- Hits 12522 12517 -5
+ Misses 4340 4334 -6
+ Partials 1429 1427 -2
|
mathspanda
force-pushed
the
bash-aliyun
branch
from
49c7700 to
3cbae41
Compare
|
@fuweid PTAL. |
mathspanda
force-pushed
the
bash-aliyun
branch
from
3cbae41 to
9fa679f
Compare
mathspanda
force-pushed
the
bash-aliyun
branch
from
9fa679f to
1098d60
Compare
starnop
reviewed
Nov 1, 2018
| @@ -139,6 +139,7 @@ Environment="KUBELET_EXTRA_ARGS=--container-runtime=remote --container-runtime-e | |||
| EOF | |||
|
|
|||
| sudo systemctl daemon-reload | |||
| sudo systemctl start kubelet | |||
There was a problem hiding this comment.
Change it into restart. I think it might be necessary since kubelet config changed.
There was a problem hiding this comment.
In fact, kubelet will be started automatically in the process of kubeadm init, but it's ok too. :)
There was a problem hiding this comment.
OK, i got it. THX. Delete it.
|
Have you tested it in your local environment? If not, please take it. Thanks! |
|
@starnop Have tested. |
mathspanda
force-pushed
the
bash-aliyun
branch
from
1098d60 to
3814e46
Compare
mathspanda
force-pushed
the
bash-aliyun
branch
2 times, most recently
from
8627081 to
e0ecd08
Compare
…m aliyun mirrors Signed-off-by: mathspanda <mathspanda826@gmail.com>
mathspanda
force-pushed
the
bash-aliyun
branch
from
e0ecd08 to
8c675a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2402 +/- ##
==========================================
+ Coverage 68.45% 68.47% +0.01%
==========================================
Files 275 275
Lines 18291 18291
==========================================
+ Hits 12522 12524 +2
+ Misses 4340 4339 -1
+ Partials 1429 1428 -1
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2402 +/- ##
==========================================
+ Coverage 68.45% 68.47% +0.01%
==========================================
Files 275 275
Lines 18291 18291
==========================================
+ Hits 12522 12524 +2
+ Misses 4340 4339 -1
+ Partials 1429 1428 -1
|
|
@starnop could we move on? |
|
Sorry for delay it, I have tested it locally and LGTM. Thanks for your contribution. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mathspanda mathspanda826@gmail.com
Ⅰ. Describe what this PR did
Replace kubernetes deployment steps on ubuntu in allinone_aliyun.sh into apt-installing from aliyun mirrors, instead of downloading k8s components from googleapis.com.
Ⅱ. Does this pull request fix one issue?
#2397
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
None
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
None