oci: add pouch default runtime spec #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2411 +/- ##
==========================================
+ Coverage 69.11% 69.32% +0.21%
==========================================
Files 278 279 +1
Lines 18689 18820 +131
==========================================
+ Hits 12916 13047 +131
- Misses 4297 4299 +2
+ Partials 1476 1474 -2
|
This was referenced Nov 2, 2018
rudyfly
reviewed
Nov 6, 2018
| @@ -0,0 +1,194 @@ | |||
| package oci | |||
There was a problem hiding this comment.
too many packages in pouch directory，can we merge them？
There was a problem hiding this comment.
Give some advise ? @rudyfly
fuweid
reviewed
Nov 20, 2018
rudyfly
reviewed
Dec 3, 2018
|
I have checked |
pouchrobot
added
the
LGTM
|
@rudyfly, any update here? |
|
@fuweid yes， it need update. I remove LGTM |
rudyfly
removed
the
LGTM
|
/cc @rudyfly |
|
LGTM |
pouchrobot
added
the
LGTM
use pouch default runtime spec, instead of containerd default spec, compare to containerd spec, we remove Root, Process(Env Cmd NoNewPrivileges User Rlimits), Linux(CgroupsPath), this should not be exist in default spec, remove Mount(/run), this is not used, add allowed device, add cgroup mount. Signed-off-by: Ace-Tang <aceapril@126.com>
change shm size in mount option instead of append one more size in option. remove set shm-size in user-define mount, since if the mount destination duplicate with runtime spec, it cause a error. Signed-off-by: Ace-Tang <aceapril@126.com>
Signed-off-by: Ace-Tang <aceapril@126.com>
|
Update with fix and add a test for default shm size, @rudyfly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use pouch default runtime spec, instead of containerd default spec,
compare to containerd spec, we remove Root, Process(Env Cmd
NoNewPrivileges User Rlimits), Linux(CgroupsPath), this should not
be exist in default spec, remove Mount(/run), this is not used, add
allowed device, add cgroup mount.
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
use pouch default runtime spec, instead of containerd default spec,
compare to containerd spec, we remove Root, Process(Env Cmd
NoNewPrivileges User Rlimits), Linux(CgroupsPath), this should not
be exist in default spec, remove Mount(/run), this is not used, add
allowed device, add cgroup mount.
Ⅱ. Does this pull request fix one issue?
fix #2116 , and base on PR #2271 ， close #2115
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
no.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
For the default runtime spec pouch used, I will post an explanation, if have doubt with the new spec , please wait some time.