fix: kata: workaround passthru net mode when get pod ip #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ace-Tang <aceapril@126.com>
Codecov Report
|
HusterWan
reviewed
Nov 6, 2018
| @@ -608,6 +614,10 @@ func (c *CriManager) PodSandboxStatus(ctx context.Context, r *runtime.PodSandbox | |||
| } | |||
| } | |||
|
|
|||
| if v, exist := annotations[passthruKey]; exist && v == "true" { | |||
| ip = annotations[passthruIP] | |||
There was a problem hiding this comment.
No need to check the existence of passthruIP?
There was a problem hiding this comment.
passthruIP can be empty string?
|
Do we need to fix cri/v1alpha1/cri.go? This fixes v1alpha2. |
|
LGTM |
pouchrobot
added
the
LGTM
v1alpha1 is deprecated. We won't provide the maintenance. |
flyer103
reviewed
Nov 6, 2018
| @@ -74,6 +74,12 @@ const ( | |||
|
|
|||
| // networkNotReadyReason is the reason reported when network is not ready. | |||
| networkNotReadyReason = "NetworkPluginNotReady" | |||
|
|
|||
| // passthruKey to specify whether a interface is passthru to qemu | |||
| passthruKey = "io.alibaba.pouch.runv.passthru" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
kata: workaround passthru net mode when get pod ip
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
cherry-pick