refactor: use raw system call instead of clone-and-read-from-stdout to boost GetKernelVersion. #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2463 +/- ##
=========================================
Coverage ? 68.93%
=========================================
Files ? 277
Lines ? 18297
Branches ? 0
=========================================
Hits ? 12613
Misses ? 4256
Partials ? 1428
|
HusterWan
reviewed
Nov 10, 2018
SimonCqk
force-pushed
the
master
branch
2 times, most recently
from
e6aab7f to
4ce6826
Compare
|
@fuweid sorry to trouble you, I've done that. |
|
LGTM also cc @allencloud |
HusterWan
suggested changes
Nov 11, 2018
HusterWan
suggested changes
Nov 11, 2018
…o boost GetKernelVersion. Signed-off-by: Simoncqk <cqk0100@gmail.com>
HusterWan
reviewed
Nov 11, 2018
| // BenchmarkGetUnameByUnix-4 200000 10584 ns/op | ||
| // BenchmarkGetUnameByExecRun-4 200 6255530 ns/op | ||
|
|
||
| // Benchmark for executing `uname` by raw unix system call |
There was a problem hiding this comment.
Just asking, how long this two Benchmark case execute?
There was a problem hiding this comment.
the result shows 4.135s
HusterWan
approved these changes
Nov 11, 2018
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simoncqk cqk0100@gmail.com
Ⅰ. Describe what this PR did
refactor: use raw system call instead of clone-and-read-from-stdout to boost GetKernelVersion. Original
exec.Runcloned a new process which caused performance hot spot.Ⅱ. Does this pull request fix one issue?
fixes#2459
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
kernel_test.go has covered this case.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews