Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update runc version to 1.0.0-rc6-1 #2516

Merged
merged 1 commit into from
Dec 4, 2018
Merged

ci: update runc version to 1.0.0-rc6-1 #2516

merged 1 commit into from
Dec 4, 2018

Conversation

Ace-Tang
Copy link
Contributor

update runc version used by integration test

Signed-off-by: Ace-Tang aceapril@126.com

Ⅰ. Describe what this PR did

Now we still use a very old runc base on version v1.0.0-rc4, since v1.0.0-rc6 have been released, and bring lots of feature and bufixs, so let's update runc version

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@043a3ae). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2516   +/-   ##
=========================================
  Coverage          ?   68.57%           
=========================================
  Files             ?      278           
  Lines             ?    19110           
  Branches          ?        0           
=========================================
  Hits              ?    13105           
  Misses            ?     4498           
  Partials          ?     1507
Flag Coverage Δ
#criv1alpha1test 31.27% <ø> (?)
#criv1alpha2test 35.45% <ø> (?)
#integrationtest 40.46% <ø> (?)
#nodee2etest 32.63% <ø> (?)
#unittest 26.75% <ø> (?)

@fuweid
Copy link
Contributor

fuweid commented Nov 29, 2018

LGTM but we also need to update the package script https://github.com/pouchcontainer/project

@Ace-Tang
Copy link
Contributor Author

Yes, let make this step by step

@Ace-Tang
Copy link
Contributor Author

----------------------------------------------------------------------
FAIL: /home/travis/gopath/src/github.com/alibaba/pouch/test/cli_start_test.go:301: PouchStartSuite.TestStartFromCheckpoint
/home/travis/gopath/src/github.com/alibaba/pouch/test/cli_start_test.go:320:
    command.PouchRun("start", "--checkpoint-dir", tmpDir, "--checkpoint", checkpoint, restoredContainer).Assert(c, icmd.Success)
/home/travis/gopath/src/github.com/alibaba/pouch/vendor/github.com/gotestyourself/gotestyourself/icmd/command.go:61:
    t.Fatalf("at %s:%d - %s\n", filepath.Base(file), line, err.Error())
... Error: at cli_start_test.go:320 - 
Command:  /usr/local/bin/pouch start --checkpoint-dir /tmp/checkpoint238978016 --checkpoint cp0 restoredContainer
ExitCode: 1
Error:    exit status 1
Stdout:   
Stderr:   Error: failed to start containers: {"message":"failed to create container(2ef957c52ff1566d7659cf2e7af065327a32ada185d8190fdb42437bcbf09600) on containerd: failed to start task(0) in container(2ef957c52ff1566d7659cf2e7af065327a32ada185d8190fdb42437bcbf09600): failed to retrieve OCI runtime container pid: open /var/lib/pouch/containerd/state/io.containerd.runtime.v1.linux/default/2ef957c52ff1566d7659cf2e7af065327a32ada185d8190fdb42437bcbf09600/init.pid: no such file or directory: unknown"}
Failures:
ExitCode was 1 expected 0
Expected no error

really wired ci fails but test on my machine is passed

$ go test -check.f TestStartFromCheckpoint
OK: 1 passed
PASS
ok  	github.com/alibaba/pouch/test	3.594s

$ runc -v
runc version 1.0.0-rc6-1
commit: cb0fd7d117bbc3d9f81592531b0d0bc3def09864
spec: 1.0.1-dev

update runc version used by integration test

Signed-off-by: Ace-Tang <aceapril@126.com>
@fuweid
Copy link
Contributor

fuweid commented Nov 30, 2018

@Ace-Tang I can reproduce it in my env. still thinking it out.

@Ace-Tang
Copy link
Contributor Author

I have no idea whether criu test have broken, so I complete the criu test to check #2520

@Ace-Tang
Copy link
Contributor Author

Compare with two runc version, the one can do c/r successful is version 1.0.0-rc4
and the new one 1.0.0-rc6-1 fails with criu log

(00.028294) Warn  (criu/cr-restore.c:853): Set CLONE_PARENT | CLONE_NEWPID but it might cause restore problem,because not all kernels support such clone flags combinations!
(00.028299) Forking task with 1 pid (flags 0x6c028000)
(00.028825) PID: real 27352 virt 1
(00.028903) Wait until namespaces are created
(00.032388)      1: Found fd 0 (id pipe:[3463568]) in inherit fd list (caller close_old_fds)
(00.032414)      1: Found fd 1 (id pipe:[3463569]) in inherit fd list (caller close_old_fds)
(00.032418)      1: Found fd 2 (id pipe:[3463570]) in inherit fd list (caller close_old_fds)
(00.032548) Running setup-namespaces scripts
(00.032555)     RPC 
(00.088106) Client exited unexpectedly
(00.088135) Error (criu/action-scripts.c:116): One of more action scripts failed
(00.108497) Error (criu/cr-restore.c:1024): 27352 killed by signal 9: Killed
(00.152085) mnt: Switching to new ns to clean ghosts
(00.152216) Error (criu/cr-restore.c:1890): Restoring FAILED.
(00.152250) Error (criu/cr-service.c:102): Can't send response: Broken pipe
(00.152260) Error (criu/cr-service.c:567): Can't send response: Broken pipe

@Ace-Tang
Copy link
Contributor Author

Ace-Tang commented Nov 30, 2018

Without this runc pr opencontainers/runc#1741 , our test can pass, but I need to do more check why the fail has related with this pr.

@Ace-Tang
Copy link
Contributor Author

Ace-Tang commented Dec 4, 2018

@fuweid , criu test fail has been fixed

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 9ed34bb into AliyunContainerService:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants