-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update runc version to 1.0.0-rc6-1 #2516
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2516 +/- ##
=========================================
Coverage ? 68.57%
=========================================
Files ? 278
Lines ? 19110
Branches ? 0
=========================================
Hits ? 13105
Misses ? 4498
Partials ? 1507
|
LGTM but we also need to update the package script https://github.com/pouchcontainer/project |
Yes, let make this step by step |
really wired ci fails but test on my machine is passed
|
update runc version used by integration test Signed-off-by: Ace-Tang <aceapril@126.com>
@Ace-Tang I can reproduce it in my env. still thinking it out. |
I have no idea whether criu test have broken, so I complete the criu test to check #2520 |
Compare with two runc version, the one can do c/r successful is version
|
Without this runc pr opencontainers/runc#1741 , our test can pass, but I need to do more check why the fail has related with this pr. |
@fuweid , criu test fail has been fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
update runc version used by integration test
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
Now we still use a very old runc base on version
v1.0.0-rc4
, sincev1.0.0-rc6
have been released, and bring lots of feature and bufixs, so let's update runc versionⅡ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews