cleanup: rm runtime.Caller with const func name #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangyue <zy675793960@yeah.net>
Codecov Report
@@ Coverage Diff @@
## master #2523 +/- ##
=========================================
- Coverage 69.1% 69% -0.11%
=========================================
Files 278 278
Lines 18454 18454
=========================================
- Hits 12753 12734 -19
- Misses 4251 4264 +13
- Partials 1450 1456 +6
|
|
@ZYecho I think we can upgrade the go-check package so that we can use https://godoc.org/gopkg.in/check.v1#C.TestName to get the function name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhangyue zy675793960@yeah.net
Ⅰ. Describe what this PR did
As the title desc, just clean up some test code to make more readable.
Ⅱ. Does this pull request fix one issue?
None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
None.
Ⅳ. Describe how to verify it
wait for CI pass.
Ⅴ. Special notes for reviews
None.