-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: fullfill network scope field in network ls
and inspect
#2532
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2532 +/- ##
==========================================
- Coverage 69.2% 69.15% -0.05%
==========================================
Files 278 278
Lines 18494 18508 +14
==========================================
+ Hits 12798 12799 +1
- Misses 4243 4246 +3
- Partials 1453 1463 +10
|
UT failed, you can rebase master, and rebuild ci |
Actually I do not think it is the UT test failure:
It seems to be travis CI 's own issue. @mathspanda @rudyfly I think we could ignore this. |
fullfill scope value returned in pouch network list/inpsect Signed-off-by: mathspanda <mathspanda826@gmail.com>
network ls
and inspect
@@ -48,10 +48,12 @@ func (suite *PouchNetworkSuite) TestNetworkInspectFormat(c *check.C) { | |||
c.Errorf("failed to decode inspect output: %v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just confirm, no network ls
corresponding cli test case added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap. I haven't seen any cli test about network ls
. Maybe needed if network ls
support some flags.
LGTM |
Signed-off-by: mathspanda mathspanda826@gmail.com
Ⅰ. Describe what this PR did
Fullfill scope value returned in pouch network list/inpsect.
Ⅱ. Does this pull request fix one issue?
issue #2501
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Added.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
None