Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Clean up temporary test file #2535

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

zjumoon01
Copy link
Contributor

Clean /tmp/TestRunWithHostFileVolume.md after test

Signed-off-by: Wang Rui baijia.wr@antfin.com

Ⅰ. Describe what this PR did

Cleanup /tmp/TestRunWithHostFileVolume.md which is created in test case.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Check /tmp/TestRunWithHostFileVolume.md file exists after running test case cli_run_volume_test.go:TestRunWithHostFileVolume .
After this patch, this file will be cleaned after the test.

Ⅴ. Special notes for reviews

Clean /tmp/TestRunWithHostFileVolume.md after test

Signed-off-by: Wang Rui <baijia.wr@antfin.com>
@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #2535 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2535      +/-   ##
=========================================
+ Coverage    69.2%   69.2%   +<.01%     
=========================================
  Files         278     278              
  Lines       18494   18494              
=========================================
+ Hits        12798   12799       +1     
+ Misses       4243    4236       -7     
- Partials     1453    1459       +6
Flag Coverage Δ
#criv1alpha1test 31.33% <ø> (+0.01%) ⬆️
#criv1alpha2test 35.43% <ø> (+0.16%) ⬆️
#integrationtest 40.55% <ø> (+0.01%) ⬆️
#nodee2etest 32.66% <ø> (-0.13%) ⬇️
#unittest 26.91% <ø> (ø) ⬆️
Impacted Files Coverage Δ
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
daemon/mgr/container_utils.go 85.44% <0%> (-1.27%) ⬇️
cri/v1alpha2/cri_wrapper.go 62.4% <0%> (-1.21%) ⬇️
cri/v1alpha2/cri.go 69.43% <0%> (-0.51%) ⬇️
daemon/mgr/container.go 59.12% <0%> (-0.22%) ⬇️
ctrd/container.go 59.2% <0%> (+1.18%) ⬆️
ctrd/watch.go 84.5% <0%> (+2.81%) ⬆️
pkg/streams/utils.go 91.66% <0%> (+9.52%) ⬆️

@rudyfly
Copy link
Collaborator

rudyfly commented Dec 5, 2018

Can you modify the PR title to this format: test: clean up temporary test file
More detail you can see: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md#commit-message

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Dec 5, 2018
@allencloud allencloud removed the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Dec 5, 2018
@allencloud allencloud changed the title Clean up temporary test file test: Clean up temporary test file Dec 5, 2018
@allencloud
Copy link
Collaborator

LGTM, I have updated the pr title name to add the prefix.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Dec 5, 2018
@allencloud allencloud merged commit 0ae7ed7 into AliyunContainerService:master Dec 5, 2018
@zjumoon01 zjumoon01 deleted the bugfix branch December 5, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants