Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: volume test fails in custom version pouch #2542

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

zhuangqh
Copy link
Contributor

@zhuangqh zhuangqh commented Dec 7, 2018

Signed-off-by: zhuangqh zhuangqhc@gmail.com

Ⅰ. Describe what this PR did

test TestRunWithVolumeCopyData may fails with some custom version busybox image.

This PR make TestRunWithVolumeCopyData compatible with different situation

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

make TestRunWithVolumeCopyData compatible with different situation

Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #2542 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2542      +/-   ##
==========================================
+ Coverage   69.12%   69.22%   +0.09%     
==========================================
  Files         278      278              
  Lines       18528    18528              
==========================================
+ Hits        12808    12826      +18     
+ Misses       4255     4241      -14     
+ Partials     1465     1461       -4
Flag Coverage Δ
#criv1alpha1test 31.2% <ø> (-0.09%) ⬇️
#criv1alpha2test 35.48% <ø> (-0.04%) ⬇️
#integrationtest 40.64% <ø> (+0.09%) ⬆️
#nodee2etest 32.7% <ø> (-0.05%) ⬇️
#unittest 26.85% <ø> (ø) ⬆️
Impacted Files Coverage Δ
ctrd/container.go 58.81% <0%> (-0.4%) ⬇️
daemon/mgr/container.go 58.69% <0%> (ø) ⬆️
cri/v1alpha2/cri_wrapper.go 63.6% <0%> (ø) ⬆️
cri/v1alpha2/cri.go 69.93% <0%> (ø) ⬆️
daemon/mgr/container_utils.go 83.92% <0%> (+0.59%) ⬆️
ctrd/client.go 69.23% <0%> (+2.3%) ⬆️
pkg/streams/utils.go 91.66% <0%> (+2.38%) ⬆️
daemon/mgr/events.go 100% <0%> (+3.7%) ⬆️
apis/server/utils.go 75% <0%> (+3.84%) ⬆️
ctrd/watch.go 84.5% <0%> (+4.22%) ⬆️
... and 1 more

@zhuangqh zhuangqh requested a review from fuweid December 7, 2018 03:14
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM wait for CI

@fuweid fuweid merged commit 7101cf2 into AliyunContainerService:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants