bugfix: StringSliceEqual should also consider duplicate items in slice #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
==========================================
+ Coverage 69.07% 69.14% +0.06%
==========================================
Files 278 278
Lines 18564 18565 +1
==========================================
+ Hits 12823 12836 +13
+ Misses 4273 4259 -14
- Partials 1468 1470 +2
|
HusterWan
force-pushed
the
zr/fix-string-slice-equal
branch
from
1da79a5 to
37461f8
Compare
allencloud
reviewed
Dec 13, 2018
pkg/utils/utils.go
Outdated
| @@ -306,6 +306,7 @@ func IsFileExist(file string) bool { | |||
| } | |||
|
|
|||
| // StringSliceEqual compare two string slice, ignore the order. | |||
| // we also should consider if there has duplicate items in slice. | |||
There was a problem hiding this comment.
I see here you are describing the case. But for fixing a bug, we should describe the functionality it provides. Maybe you can update the comment about when this function returns true precisely. @HusterWan
zhuangqh
reviewed
Dec 14, 2018
|
|
||
| // second list all items in s2 | ||
| for _, v := range s2 { | ||
| mapKeys[v]-- |
There was a problem hiding this comment.
embedded check here for more efficient
mapKeys[v]--
if mapKeys[v] < 0 {
return false
}This check covers two situations
- if the key is not exists, mapKey[v] == -1
- if the key is redundant, mapKey[v] < 0
There was a problem hiding this comment.
you are so talented. @zhuangqh 👍 🦁 🐸 🐼
HusterWan
force-pushed
the
zr/fix-string-slice-equal
branch
3 times, most recently
from
9bc7972 to
b08a818
Compare
Signed-off-by: ziren.wzr <ziren.wzr@alibaba-inc.com>
HusterWan
force-pushed
the
zr/fix-string-slice-equal
branch
from
b08a818 to
fd23316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ziren.wzr ziren.wzr@alibaba-inc.com
Ⅰ. Describe what this PR did
When a slice have duplicate items, the
StringSliceEqualmay get wrong answerⅡ. Does this pull request fix one issue?
fixes: #2560
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews