Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test cases for mountpoint_test.go and portbindngs_test.go #2583

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

sanmaopep
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #2583 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2583      +/-   ##
==========================================
- Coverage   69.18%   69.17%   -0.02%     
==========================================
  Files         278      278              
  Lines       18689    18689              
==========================================
- Hits        12930    12928       -2     
- Misses       4285     4288       +3     
+ Partials     1474     1473       -1
Flag Coverage Δ
#criv1alpha1test 31.38% <ø> (+0.15%) ⬆️
#criv1alpha2test 35.69% <ø> (-0.1%) ⬇️
#integrationtest 40.71% <ø> (-0.05%) ⬇️
#nodee2etest 32.77% <ø> (+0.02%) ⬆️
#unittest 26.74% <ø> (+0.07%) ⬆️
Impacted Files Coverage Δ
pkg/streams/utils.go 82.14% <0%> (-9.53%) ⬇️
cri/v1alpha2/cri_wrapper.go 64.4% <0%> (-1.2%) ⬇️
cri/v1alpha2/cri.go 69.48% <0%> (-0.13%) ⬇️
cri/v1alpha1/cri.go 60.59% <0%> (+0.33%) ⬆️
ctrd/container.go 59.28% <0%> (+0.39%) ⬆️
apis/server/utils.go 75% <0%> (+3.84%) ⬆️
apis/opts/portbindings.go 100% <0%> (+19.04%) ⬆️

apis/opts/portbindings_test.go Outdated Show resolved Hide resolved
apis/opts/portbindings_test.go Show resolved Hide resolved
@sanmaopep
Copy link
Contributor Author

@ZYecho Thanks for your suggestions, I will modify them 😄

@sanmaopep sanmaopep force-pushed the testcases branch 3 times, most recently from 49c4dd4 to fb80d9f Compare December 20, 2018 07:53
@ZYecho
Copy link
Contributor

ZYecho commented Dec 20, 2018

LGTM
wait for CI pass

@allencloud
Copy link
Collaborator

Thanks for your great work.
@sanmaopep
Wish you have a great journey to participant in community.
In addition, we have a dingtalk group which contains almost all the develops and contributors of PouchContainer. Would you like to join us?

ladpdgq9qzzuft3na97nau4_750_990

@allencloud allencloud merged commit b19cbf6 into AliyunContainerService:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants