remove unused member of daemon config #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ListenCRI which is the member of daemon config, is unused. ListenCRI was first added in commit 05e4923. Commit 05e4923 was pushed on Jan 12, and merged on Mar 6. ListenCRI was deleted in commit 05e4923, which was merged on Jan 16. So, it was a mistake that the deleted ListenCRI was added back by the merge of 05e4923. Signed-off-by: Wang Rui <baijia.wr@antfin.com>
Codecov Report
@@ Coverage Diff @@
## master #2593 +/- ##
==========================================
+ Coverage 69.11% 69.19% +0.08%
==========================================
Files 278 278
Lines 18689 18689
==========================================
+ Hits 12916 12931 +15
+ Misses 4297 4284 -13
+ Partials 1476 1474 -2
|
|
LGTM, actually I did not see any usage of this parameter in non-test go files. |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListenCRI which is the member of daemon config, is unused.
ListenCRI was first added in commit 05e4923. Commit 05e4923
was pushed on Jan 12, and merged on Mar 6.
ListenCRI was deleted in commit 05e4923, which was merged on
Jan 16.
So, it was a mistake that the deleted ListenCRI was added back
by the merge of 05e4923.
Signed-off-by: Wang Rui baijia.wr@antfin.com
Ⅰ. Describe what this PR did
Remove unused code.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews