Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: move to 1.1.0 #2605

Merged
merged 1 commit into from
Dec 24, 2018
Merged

upgrade: move to 1.1.0 #2605

merged 1 commit into from
Dec 24, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Dec 24, 2018

Signed-off-by: Wei Fu fhfuwei@163.com

Ⅰ. Describe what this PR did

release PouchContainer

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Wei Fu <fhfuwei@163.com>
@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #2605 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2605      +/-   ##
==========================================
+ Coverage   69.38%   69.41%   +0.03%     
==========================================
  Files         279      279              
  Lines       18825    18825              
==========================================
+ Hits        13062    13068       +6     
+ Misses       4287     4286       -1     
+ Partials     1476     1471       -5
Flag Coverage Δ
#criv1alpha1test 31.92% <ø> (+0.17%) ⬆️
#criv1alpha2test 36.15% <ø> (-0.03%) ⬇️
#integrationtest 41.19% <ø> (ø) ⬆️
#nodee2etest 33.24% <ø> (-0.01%) ⬇️
#unittest 26.78% <ø> (ø) ⬆️
Impacted Files Coverage Δ
daemon/mgr/snapshot.go 89.85% <0%> (-4.35%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
cri/v1alpha2/cri.go 68.81% <0%> (-0.38%) ⬇️
cri/v1alpha1/cri.go 60.92% <0%> (+0.66%) ⬆️
ctrd/container.go 58.89% <0%> (+0.79%) ⬆️
daemon/mgr/container_utils.go 85.11% <0%> (+1.19%) ⬆️
pkg/meta/store.go 68.99% <0%> (+1.55%) ⬆️
pkg/streams/utils.go 91.66% <0%> (+2.38%) ⬆️

Copy link
Contributor

@Ace-Tang Ace-Tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhuangqh zhuangqh merged commit d30a76e into AliyunContainerService:master Dec 24, 2018
@fuweid fuweid deleted the upgrade-1.1.0 branch February 21, 2019 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants