config: disable snapshot syncer by default #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CRI can report the disk usage of contaienr with inode number. However, the iteration will take long time if the number of files are too much. Based on this, I think we should disable it by default. If user wants to use it, set it in config. Signed-off-by: Wei Fu <fhfuwei@163.com>
Codecov Report
@@ Coverage Diff @@
## master #2611 +/- ##
==========================================
- Coverage 69.46% 68.83% -0.64%
==========================================
Files 279 279
Lines 18833 18833
==========================================
- Hits 13083 12964 -119
- Misses 4281 4394 +113
- Partials 1469 1475 +6
|
|
Will it effect out production ? |
Not just us, if the container creates a lot of small files and user enables CRI, it will impact the performance and containerd will consume more cpu here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Fu fhfuwei@163.com
Ⅰ. Describe what this PR did
The CRI can report the disk usage of contaienr with inode number.
However, the iteration will take long time if the number of files are
too much. Based on this, I think we should disable it by default. If
user wants to use it, set it in config.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
no need
Ⅳ. Describe how to verify it
check the log
Ⅴ. Special notes for reviews