-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: change test image for container create test #2615
test: change test image for container create test #2615
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2615 +/- ##
==========================================
- Coverage 69.51% 69.43% -0.08%
==========================================
Files 279 279
Lines 18833 18833
==========================================
- Hits 13091 13077 -14
- Misses 4277 4286 +9
- Partials 1465 1470 +5
|
test/cli_create_test.go
Outdated
image := "docker.io/library/alpine" | ||
res := command.PouchRun("create", "--name", cname, image) | ||
DelImageForceOk(c, busyboxImage) | ||
res := command.PouchRun("create", "--name", cname, busyboxImage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can use command.PouchRun("create", "--name", cname, busyboxImage).Assert(c, icmd.Success)
here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make since
test/cli_create_test.go
Outdated
res.Assert(c, icmd.Success) | ||
} | ||
|
||
// TestCreateWithNonExistImage tests running container with image not exist. | ||
func (suite *PouchCreateSuite) TestCreateWithNvidiaConfig(c *check.C) { | ||
cname := "TestCreateWithNvidiaConfig" | ||
image := "docker.io/library/alpine" | ||
res := command.PouchRun("create", "--name", cname, "--nvidia-capabilities", "all", "--nvidia-visible-devs", "none", image) | ||
res := command.PouchRun("create", "--name", cname, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
test/cli_create_test.go
Outdated
image := "docker.io/library/alpine" | ||
res := command.PouchRun("create", "--name", cname, image) | ||
|
||
res := command.PouchRun("create", "--name", cname, busyboxImage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
change test image from `docker.io/library/alpine` to `busyboxImage`. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
e7544a4
to
b0a30ac
Compare
@fuweid PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
change test image from
docker.io/library/alpine
tobusyboxImage
.Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Just modify test cage.
Ⅳ. Describe how to verify it
ci pass
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com