feature: extend cri apis for support pause/unpause container #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2623 +/- ##
==========================================
- Coverage 69.59% 69.43% -0.16%
==========================================
Files 281 283 +2
Lines 18805 18827 +22
==========================================
- Hits 13087 13073 -14
- Misses 4255 4292 +37
+ Partials 1463 1462 -1
|
|
I think we should add this extension into the document. https://github.com/alibaba/pouch/blob/master/docs/kubernetes/pouch_cri_api_changelog.md |
zhuangqh
changed the title
zhuangqh
force-pushed
the
feature-cri-pause
branch
2 times, most recently
from
5ef9afb to
01703f7
Compare
fuweid
reviewed
Jan 17, 2019
cri/v1alpha2/container_pause.go
Outdated
|
|
||
| containerID := r.GetContainerId() | ||
|
|
||
| err := c.ContainerMgr.Pause(ctx, containerID) |
There was a problem hiding this comment.
nit, you can use if err := c.ContainerMgr.Pause(ctx, containerID); err != nil here.
Under serverless situation, we may pre-allocate a batch of container which were ready to serve, waiting online. In order to reduce the cost of system resource, we stop these containers, and start them when they are required to serve. Using pause container to balance the resource cost and application start-up time. Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
zhuangqh
force-pushed
the
feature-cri-pause
branch
from
01703f7 to
a08a024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
CRI support pause/unpause containers
related to #2622
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
create test to cover the new interface on cri-tools
Ⅴ. Special notes for reviews
depend on PR #2613