Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos #2626

Merged
merged 1 commit into from
Dec 28, 2018
Merged

fix: typos #2626

merged 1 commit into from
Dec 28, 2018

Conversation

chuanchang
Copy link
Contributor

Signed-off-by: Alex Jia chuanchang.jia@gmail.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Dec 28, 2018

Codecov Report

Merging #2626 into master will decrease coverage by 11.69%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2626      +/-   ##
==========================================
- Coverage   69.48%   57.78%   -11.7%     
==========================================
  Files         280      280              
  Lines       18844    18844              
==========================================
- Hits        13093    10889    -2204     
- Misses       4283     6696    +2413     
+ Partials     1468     1259     -209
Flag Coverage Δ
#criv1alpha1test 31.37% <0%> (-0.06%) ⬇️
#criv1alpha2test 35.58% <0%> (-0.09%) ⬇️
#integrationtest 52.63% <ø> (+11.04%) ⬆️
#nodee2etest 32.64% <0%> (-0.21%) ⬇️
#unittest 26.91% <100%> (ø) ⬆️
Impacted Files Coverage Δ
ctrd/image.go 65% <ø> (-13.19%) ⬇️
apis/opts/portbindings.go 100% <100%> (ø) ⬆️
daemon/logger/logmessage.go 0% <0%> (-100%) ⬇️
hookplugins/containerplugin/update_hook.go 0% <0%> (-100%) ⬇️
pkg/httputils/http_error.go 0% <0%> (-100%) ⬇️
apis/server/container_bridge.go 0% <0%> (-90.29%) ⬇️
apis/server/volume_bridge.go 0% <0%> (-87.18%) ⬇️
ctrd/image_commit.go 0% <0%> (-68.88%) ⬇️
apis/server/utils.go 3.84% <0%> (-67.31%) ⬇️
apis/server/network_bridge.go 0% <0%> (-66.13%) ⬇️
... and 75 more

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @chuanchang
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

Signed-off-by: Alex Jia <chuanchang.jia@gmail.com>
test/cli_top_test.go Outdated Show resolved Hide resolved
@fuweid fuweid changed the title fix typos fix: typos Dec 28, 2018
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Dec 28, 2018
@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @chuanchang
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/typo kind/bug This is bug report for project size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants