-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Allow multi snapshotters #2631
Merged
allencloud
merged 1 commit into
AliyunContainerService:master
from
wangforthinker:feature/support-multi-snapshotter
Jan 2, 2019
Merged
feature: Allow multi snapshotters #2631
allencloud
merged 1 commit into
AliyunContainerService:master
from
wangforthinker:feature/support-multi-snapshotter
Jan 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2631 +/- ##
==========================================
- Coverage 69.57% 68.04% -1.54%
==========================================
Files 280 280
Lines 18844 18845 +1
==========================================
- Hits 13111 12823 -288
- Misses 4268 4526 +258
- Partials 1465 1496 +31
|
LGTM |
pouchrobot
added
the
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
label
Dec 28, 2018
wangforthinker
force-pushed
the
feature/support-multi-snapshotter
branch
from
December 28, 2018 09:48
2c93355
to
3fde0e9
Compare
allencloud
changed the title
[feature] Allow multi snapshotter
feature: Allow multi snapshotters
Dec 28, 2018
allencloud
reviewed
Dec 28, 2018
allencloud
reviewed
Dec 28, 2018
allencloud
reviewed
Dec 28, 2018
I left several comments. Wish to get your feedback to move on. @wangforthinker |
wangforthinker
force-pushed
the
feature/support-multi-snapshotter
branch
from
December 28, 2018 13:25
add569a
to
5756e6a
Compare
…in pouchd Signed-off-by: allen.wang <allen.wq@alipay.com>
wangforthinker
force-pushed
the
feature/support-multi-snapshotter
branch
2 times, most recently
from
December 29, 2018 09:30
9efe156
to
bd79050
Compare
Look good to me, /cc @allencloud |
Thanks for your review. Merging... @Ace-Tang |
PR should not be added to fixed, #2585 was closed by error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add a daemon config allow-multi-snapshotter, if set true, pouchd will allow multi snapshotter.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Add test.
Ⅳ. Describe how to verify it
Add a flag allow-multi-snapshotter, if set true, pouchd will ignore check multi snapshotter snapshots.
Ⅴ. Special notes for reviews